0
Under review

Alpha 0.14 Panner node sometimes disconnects and break shaders

Marc 10 years ago updated by Freya Holmér (Developer) 10 years ago 7

Admin Edit: Renamed title

Original title was "Alpha 0.14 - shader breaks and no longer compiles.".

Original post below:

I did something to my shader, I don't know what, but it broke it.  Now no matter what I do it can never be fixed.  I get his error - 


NullReferenceException: Object reference not set to an instance of an object

ShaderForge.SF_Node.GetInputData (System.String id)

ShaderForge.SFN_Panner.IsUniformOutput ()

ShaderForge.SF_NodePreview.Combine ()

ShaderForge.SF_Node.RefreshValue (Int32 ia, Int32 ib)

ShaderForge.SFN_Panner.OnUpdateNode (NodeUpdateType updType, Boolean cascade)

ShaderForge.SF_NodeConnection.Disconnect (Boolean force, Boolean callback)

ShaderForge.SF_NodeConnection.LinkTo (ShaderForge.SF_NodeConnection other, LinkingMethod linkMethod)

ShaderForge.SF_EditorNodeView.ReconnectConnectedPending ()

ShaderForge.SF_Parser.LoadFromNodeData (System.String data)

ShaderForge.SF_Parser.ParseNodeDataFromShader (ShaderForge.SF_Editor editor, UnityEngine.Shader s)

ShaderForge.SF_Editor.InitializeInstance (UnityEngine.Shader initShader)

ShaderForge.SF_Editor.Init (UnityEngine.Shader initShader)

ShaderForge.SF_Editor.DrawMainMenu ()

ShaderForge.SF_Editor.OnGUI ()

System.Reflection.MonoMethod.Invoke (System.Object obj, BindingFlags invokeAttr, System.Reflection.Binder binder, System.Object[] parameters, System.Globalization.CultureInfo culture) (at /Users/builduser/buildslave/monoAndRuntimeClassLibs/build/mcs/class/corlib/System.Reflection/MonoMethod.cs:222)


and on a side-note if I close it and reopen it, sometimes some of the connections are not connected.

How does the node setup look?

give me a chance to rebuild. I deleted the shader.  I'll try to repro the problem but it happened to me three times in row so it should be easy.

So I was not able to repro the bug anymore, but I did find another issue, that I suspect is actually the cause of this bug - 




As you can see, after loading up SF to modify a shader, you can see there's a disconnection in the nodes.  This happens for many of my nodes.  They seem to work, then I open them to modify and need to fix them.


I think this may have been my problem.  If that's happening, then I can definitely see it causing issues if a shader has a dependency and that dependency is disconnected.

It seems to be a bug with the panner node since 0.14, I'll have to look into it :)

Thanks a bunch for the help!

Fantastic!  speaking of which, are there plans to expose the panner node values?

Not really, but you can make a manual panner :)