0
Under review

Bug with double sided face culling

Rob Lloyd 9 year бұрын updated by JT Burke 9 year бұрын 4
when setting face culling to double sided in deferred lighting mode and dx11, the frag shader puts a close brace before the end of the parameters


void frag(
VertexOutput i,
out half4 outDiffuse : SV_Target0,
out half4 outSpecSmoothness : SV_Target1,
out half4 outNormal : SV_Target2,
out half4 outEmission : SV_Target3 ), <---- error here
float facing : VFACE
{
Under review
I'll look into that for 1.19
This bug is still active in v1.21, bumped into it this morning. I'll post shaderforge code generation below, so you can recreate the shader for testing.


// Shader created with Shader Forge v1.21 // Shader Forge (c) Neat Corporation / Joachim Holmer - http://www.acegikmo.com/shaderforge/ // Note: Manually altering this data may prevent you from opening it in Shader Forge /*SF_DATA;ver:1.21;sub:START;pass:START;ps:flbk:,iptp:0,cusa:False,bamd:0,lico:1,lgpr:1,limd:3,spmd:0,trmd:0,grmd:0,uamb:True,mssp:True,bkdf:True,hqlp:False,rprd:True,enco:False,rmgx:True,rpth:1,vtps:0,hqsc:True,nrmq:1,nrsp:0,vomd:0,spxs:False,tesm:0,olmd:1,culm:2,bsrc:0,bdst:1,dpts:2,wrdp:True,dith:0,rfrpo:True,rfrpn:Refraction,coma:15,ufog:True,aust:True,igpj:False,qofs:0,qpre:1,rntp:1,fgom:False,fgoc:False,fgod:False,fgor:False,fgmd:0,fgcr:0.5,fgcg:0.5,fgcb:0.5,fgca:1,fgde:0.01,fgrn:0,fgrf:300,stcl:False,stva:128,stmr:255,stmw:255,stcp:6,stps:0,stfa:0,stfz:0,ofsf:0,ofsu:0,f2p0:False;n:type:ShaderForge.SFN_Final,id:2865,x:32719,y:32712,varname:node_2865,prsc:2|diff-6343-OUT,spec-4606-OUT,gloss-2712-OUT,emission-3847-OUT,voffset-6652-OUT;n:type:ShaderForge.SFN_Multiply,id:6343,x:32515,y:32560,varname:node_6343,prsc:2|A-9962-RGB,B-6665-RGB;n:type:ShaderForge.SFN_Color,id:6665,x:32292,y:32560,ptovrint:False,ptlb:Color,ptin:_Color,varname:_Color,prsc:2,glob:False,taghide:False,taghdr:False,tagprd:False,tagnsco:False,tagnrm:False,c1:0.5019608,c2:0.5019608,c3:0.5019608,c4:1;n:type:ShaderForge.SFN_VertexColor,id:9962,x:32292,y:32415,varname:node_9962,prsc:2;n:type:ShaderForge.SFN_Color,id:2033,x:32135,y:32893,ptovrint:False,ptlb:Emission,ptin:_Emission,varname:node_2033,prsc:2,glob:False,taghide:False,taghdr:False,tagprd:False,tagnsco:False,tagnrm:False,c1:0.5,c2:0.5,c3:0.5,c4:1;n:type:ShaderForge.SFN_Slider,id:4606,x:32358,y:32727,ptovrint:False,ptlb:Specular,ptin:_Specular,varname:node_4606,prsc:2,glob:False,taghide:False,taghdr:False,tagprd:False,tagnsco:False,tagnrm:False,min:0,cur:0,max:1;n:type:ShaderForge.SFN_Slider,id:2712,x:32358,y:32818,ptovrint:False,ptlb:Gloss,ptin:_Gloss,varname:node_2712,prsc:2,glob:False,taghide:False,taghdr:False,tagprd:False,tagnsco:False,tagnrm:False,min:0,cur:0,max:1;n:type:ShaderForge.SFN_Multiply,id:3847,x:32515,y:32893,varname:node_3847,prsc:2|A-2033-RGB,B-5417-OUT;n:type:ShaderForge.SFN_Slider,id:9031,x:32135,y:33057,ptovrint:False,ptlb:HDR,ptin:_HDR,varname:node_9031,prsc:2,glob:False,taghide:False,taghdr:False,tagprd:False,tagnsco:False,tagnrm:False,min:0,cur:0,max:1;n:type:ShaderForge.SFN_RemapRange,id:5417,x:32515,y:33042,varname:node_5417,prsc:2,frmn:0,frmx:1,tomn:1,tomx:2|IN-9031-OUT;n:type:ShaderForge.SFN_Time,id:3185,x:31670,y:33398,varname:node_3185,prsc:2;n:type:ShaderForge.SFN_ValueProperty,id:6240,x:31670,y:33341,ptovrint:False,ptlb:Speed,ptin:_Speed,varname:_Speed,prsc:2,glob:False,taghide:False,taghdr:False,tagprd:False,tagnsco:False,tagnrm:False,v1:0.0001;n:type:ShaderForge.SFN_TexCoord,id:7038,x:31670,y:33177,varname:node_7038,prsc:2,uv:0;n:type:ShaderForge.SFN_Code,id:6652,x:31947,y:33222,varname:node_6652,prsc:2,code:aQBmACAAKABmAHIAYQBjACgAdQB2AC4AeAApACAAPgAgADAALgAwACAAJgAmACAAZgByAGEAYwAoAHUAdgAuAHkAKQAgAD4AIAAwAC4AMAApACAAewAKACAAIAAgAC8ALwAgAEMAYQBsAGMAdQBsAGEAdABlACAAdwBhAHYAZQAgAG8AZgBmAHMAZQB0AC4ACgAgACAAIABmAGwAbwBhAHQAMgAgAHgAeQAgAD0AIABmAGwAbwBhAHQAMgAoAHQAaQBtAGUAIAAqACAAcwBwAGUAZQBkACAAKwAgAHUAdgAuAHgALAAgAHUAdgAuAHkAKQA7AAoAIAAgACAALwAvACAALgAuAC4AIABTAGgAYQBkAGUAcgBGAG8AcgBkAGUAIAAnAG4AbwBpAHMAZQAnACAAZgB1AG4AYwB0AGkAbwBuAC4ACgAgACAAIABmAGwAbwBhAHQAMgAgAHMAawBlAHcAIAA9ACAAeAB5ACAAKwAgADAALgAyADEAMgA3ACAAKwAgAHgAeQAuAHgAIAAqACAAMAAuADMANwAxADMAIAAqACAAeAB5AC4AeQA7AAoAIAAgACAAZgBsAG8AYQB0ADIAIAByAGEAbgBkAG8AbQAgAD0AIAA0AC4ANwA4ADkAIAAqACAAcwBpAG4AKAA0ADgAOQAuADEAMgAzACAAKgAgAHMAawBlAHcAKQA7AAoAIAAgACAAZgBsAG8AYQB0ACAAbgBvAGkAcwBlACAAPQAgAGYAcgBhAGMAKAByAGEAbgBkAG8AbQAuAHgAIAAqACAAcgBhAG4AZABvAG0ALgB5ACAAKgAgACgAMQAgACsAIABzAGsAZQB3AC4AeAApACkAOwAKACAAIAAgAHIAZQB0AHUAcgBuACAAZgBsAG8AYQB0ADMAKAAwACwAIABuAG8AaQBzAGUAIAAqACAAcwBpAHoAZQAsACAAMAApADsACgB9ACAAZQBsAHMAZQAgAHsACgAgACAAIAByAGUAdAB1AHIAbgAgAGYAbABvAGEAdAAzACgAMAAsACAAMAAsACAAMAApADsACgB9AA==,output:2,fname:Function_node_2753,width:733,height:423,input:1,input:0,input:0,input:0,input_1_label:uv,input_2_label:speed,input_3_label:time,input_4_label:size|A-7038-UVOUT,B-6240-OUT,C-3185-T,D-9399-OUT;n:type:ShaderForge.SFN_ValueProperty,id:9399,x:31670,y:33544,ptovrint:False,ptlb:Size,ptin:_Size,varname:node_5182,prsc:2,glob:False,taghide:False,taghdr:False,tagprd:False,tagnsco:False,tagnrm:False,v1:0.5;proporder:6665-2033-4606-2712-9031-6240-9399;pass:END;sub:END;*/
Ah, sorry, missed this one! Will prioritize it
+1

This bug is still here. +1